feat: react-simple-dialog 패키지 구현 및 Dialog 컴포넌트 아키텍처 개선#39
Merged
sooster910 merged 3 commits intomainfrom Aug 23, 2025
Merged
Conversation
…rchitecture • Created standalone @hensley-ui/react-simple-dialog package - Promise-based imperative API for simple confirm/cancel dialogs - Comprehensive English and Korean documentation - Full test coverage with TypeScript support • Centralized Dialog components in base-ui/ui/dialog.tsx - Eliminated code duplication across packages - Maintained ShadCN styling and Radix UI accessibility - Fixed circular dependency issues in package architecture • Removed legacy SimpleDialog implementation - Cleaned up 8 duplicate files in src/components/simpleDialog/ - Updated imports to use centralized base-ui components - Fixed ESLint configuration for new package structure Resolves #18: react-simple-dialog package development 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: c392405 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
• Deleted src/components/dialog/Dialog.stories.tsx - Eliminates duplicate storybook documentation - Dialog stories now exclusively managed in react-simple-dialog package • Aligns with long-term package architecture strategy - UI package serves as simple re-export hub - Individual packages maintain their own complete documentation - Reduces maintenance overhead and developer confusion 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
📋 개요
@hensley-ui/react-simple-dialog패키지 개발base-ui/ui/dialog.tsx로 중앙화하여 코드 중복 제거🚀 주요 변경사항
🎯 새로운 React Simple Dialog 패키지
@hensley-ui/react-simple-dialog🏗️ 아키텍처 개선사항
src/components/ui/에서base-ui/ui/로 이동📊 기존 방식과의 비교
사용법 비교
기존 ShadCN Dialog:
새로운 SimpleDialog:
📁 파일 변경사항
추가된 파일
packages/ui/react-simple-dialog/- 완전한 패키지 구현packages/ui/base-ui/ui/dialog.tsx- 중앙화된 dialog 컴포넌트수정된 파일
packages/ui/src/index.ts- 새 패키지에서 re-exportpackages/ui/package.json- workspace 의존성 추가packages/ui/eslint.config.js- 빌드 아티팩트 ignore 추가제거된 파일
packages/ui/src/components/simpleDialog/- 레거시 구현 (8개 파일)packages/ui/src/components/ui/dialog.tsx- 이제 base-ui에서 re-export✅ 테스트 계획
🔄 호환성
📈 기대 효과
🤖 Generated with Claude Code